dnsdist: Always store the OpenSSLTLSIOCtx in the connection
#14671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10882923159Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
rgacogne
force-pushed
the
ddist-store-tlsioctx
branch
from
a63ace5
to
37c4e8e
Compare
omoerbeek
approved these changes
Sep 17, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Instead of storing the frontend context for server-side connection and the
SSL_CTX*for client-side.The first commit in this PR fixes a race condition where reloading the certificate and key via
reloadAllCertificates(), for example, could cause theALPN-related data to be destroyed while it was still used by an existing TLS connection. The time window to trigger the issue is quite narrow becauseALPNdata is only accessed during the initial handshake, but we have got one report of it happening in the wild, and TSAN confirms the race. This is not a security issue since it cannot be triggered without administrative access to dnsdist.The remaining commits are making this code more clean and robust, and should probably not be backported.
I would recommend reviewing this PR commit per commit!
Checklist
I have: